Merged
Conversation
kchibisov
requested changes
Mar 24, 2024
Member
kchibisov
left a comment
There was a problem hiding this comment.
I'd say that we shouldn't add that many #[allow(dead_code)] statements. Probably better to use other cfgs if we already adding one.
Contributor
Author
|
@madsmtm The iOS failure in CI looks spurious to me, am I correct? |
Contributor
Author
In many cases we can't use |
Member
I'd guess so |
daxpedda
requested changes
Mar 26, 2024
It appears that clippy's dead code detection has gotten better. This commit fixes winit's code to match. Signed-off-by: John Nunley <dev@notgull.net>
7fc5d60 to
3a7c8f5
Compare
kchibisov
approved these changes
Mar 26, 2024
daxpedda
approved these changes
Mar 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It appears that clippy's dead code detection has gotten better. This
commit fixes winit's code to match.
changelogmodule if knowledge of this change could be valuable to users