Skip to content

On Wayland, pre-multiply alpha for custom cursor#3445

Merged
kchibisov merged 2 commits intorust-windowing:masterfrom
kchibisov:wayland-fix-custom-cursor
Jan 30, 2024
Merged

On Wayland, pre-multiply alpha for custom cursor#3445
kchibisov merged 2 commits intorust-windowing:masterfrom
kchibisov:wayland-fix-custom-cursor

Conversation

@kchibisov
Copy link
Copy Markdown
Member

@kchibisov kchibisov commented Jan 30, 2024 •
edited
Loading

Fixes: #3360

  • Tested on all platforms changed
  • Added an entry to CHANGELOG.md if knowledge of this change could be valuable to users
  • Updated documentation to reflect any user-facing changes, including notes of platform-specific behavior
  • Created or updated an example program if it would help users understand this functionality
  • Updated feature matrix, if new features were added or implemented

--

@daxpedda I guess we should document whether alpha is premultiplied or not? The assumption is that it's probably not premultiplied?

@daxpedda
Copy link
Copy Markdown
Member

daxpedda commented Jan 30, 2024

Yes, it should not be pre-multiplied and you are correct, we should most definitely be documented.

Web already presumes it's not pre-multiplied:

winit/src/platform_impl/web/cursor.rs

Line 602 in df8805c

options.premultiply_alpha(PremultiplyAlpha::None);

@kchibisov kchibisov mentioned this pull request Jan 30, 2024
Closed
@kchibisov
Copy link
Copy Markdown
Member Author

kchibisov commented Jan 30, 2024

I guess that should work?

@kchibisov kchibisov force-pushed the wayland-fix-custom-cursor branch from aaa313c to b7eedc8 Compare January 30, 2024 14:27
daxpedda
daxpedda requested changes Jan 30, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@daxpedda daxpedda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM.

@kchibisov kchibisov force-pushed the wayland-fix-custom-cursor branch from b7eedc8 to bb38e6b Compare January 30, 2024 14:28
@kchibisov kchibisov force-pushed the wayland-fix-custom-cursor branch from 0555ca9 to f2fdb12 Compare January 30, 2024 14:55
daxpedda
daxpedda approved these changes Jan 30, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@daxpedda daxpedda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doc changes approved!

notgull
notgull approved these changes Jan 30, 2024
View reviewed changes
@kchibisov kchibisov merged commit cf5f4de into rust-windowing:master Jan 30, 2024
@kchibisov kchibisov deleted the wayland-fix-custom-cursor branch January 30, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daxpedda daxpedda daxpedda approved these changes

@notgull notgull notgull approved these changes

@madsmtm madsmtm Awaiting requested review from madsmtm

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

On Wayland, custom cursors don't respect alpha

3 participants

@kchibisov @daxpedda @notgull