Skip to content

macOS: Remove global HANDLER and AppState#3389

Merged
madsmtm merged 16 commits intomasterfrom
macos-no-appstate
Jan 14, 2024
Merged

macOS: Remove global HANDLER and AppState#3389
madsmtm merged 16 commits intomasterfrom
macos-no-appstate

Conversation

@madsmtm
Copy link
Copy Markdown
Member

@madsmtm madsmtm commented Jan 14, 2024

This was unnecessarily using a bunch of mutexes and atomics, which we can do away with by moving it to our ApplicationDelegate which is always accessed on the main thread.

This should make it easier for me to move towards not queuing events as much, and should also make the code-base slightly more understandable for someone who has done macOS development before (it's a common pattern to put stuff in your app delegate).

  • Tested on all platforms changed

@madsmtm madsmtm added DS - appkit Affects the AppKit/macOS backend S - maintenance Repaying technical debt labels Jan 14, 2024
@madsmtm madsmtm merged commit 40b61d2 into master Jan 14, 2024
@madsmtm madsmtm deleted the macos-no-appstate branch January 14, 2024 02:37
@madsmtm madsmtm mentioned this pull request Jan 25, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DS - appkit Affects the AppKit/macOS backend S - maintenance Repaying technical debt

Development

Successfully merging this pull request may close these issues.

1 participant