Skip to content

Web: Fix missing text content in KeyEvent for backspace and escape#3382

Closed
rparrett wants to merge 3 commits intorust-windowing:masterfrom
rparrett:web-backspace-text
Closed

Web: Fix missing text content in KeyEvent for backspace and escape#3382
rparrett wants to merge 3 commits intorust-windowing:masterfrom
rparrett:web-backspace-text

Conversation

@rparrett
Copy link
Copy Markdown

@rparrett rparrett commented Jan 11, 2024

Fixes #3381

This seems like a fairly straightforward fix. But I'm new here, so let me know if I've missed something.

I looked over the docs for KeyEvent, and I don't think any changes are necessary there.

  • Tested on all platforms changed
  • Added an entry to CHANGELOG.md if knowledge of this change could be valuable to users
  • Updated documentation to reflect any user-facing changes, including notes of platform-specific behavior
  • Created or updated an example program if it would help users understand this functionality
  • Updated feature matrix, if new features were added or implemented

@rparrett rparrett requested a review from daxpedda as a code owner January 11, 2024 03:52
@rparrett rparrett changed the title Web backspace text Fix missing text content in KeyEvent for backspace and escape Jan 11, 2024
@rparrett rparrett changed the title Fix missing text content in KeyEvent for backspace and escape web: Fix missing text content in KeyEvent for backspace and escape Jan 11, 2024
@rparrett rparrett changed the title web: Fix missing text content in KeyEvent for backspace and escape Web: Fix missing text content in KeyEvent for backspace and escape Jan 11, 2024
@daxpedda
Copy link
Copy Markdown
Member

Closing as discussed in #3381 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DS - web Affects the Web backend (WebAssembly/WASM)

Development

Successfully merging this pull request may close these issues.

KeyEvent::text should be None for backspace

2 participants