Skip to content

MacOS: check if cursor changed before applying#3324

Merged
madsmtm merged 1 commit intorust-windowing:masterfrom
daxpedda:macos-cursor-check
Dec 26, 2023
Merged

MacOS: check if cursor changed before applying#3324
madsmtm merged 1 commit intorust-windowing:masterfrom
daxpedda:macos-cursor-check

Conversation

@daxpedda
Copy link
Copy Markdown
Member

This just adds a check to make sure the cursor actually changed before applying it.

Addresses #3306.

@daxpedda daxpedda added the DS - appkit Affects the AppKit/macOS backend label Dec 26, 2023
@daxpedda daxpedda requested a review from madsmtm as a code owner December 26, 2023 13:10
@daxpedda daxpedda mentioned this pull request Dec 26, 2023
25 tasks
@daxpedda
Copy link
Copy Markdown
Member Author

daxpedda commented Dec 26, 2023

I was just thinking, that when we implement Window::cursor(), we can actually move this check into Window::set_cursor() directly covering all platforms in one place.

Let me know if you would rather wait for that.

Copy link
Copy Markdown
Member

@madsmtm madsmtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me know if you would rather wait for that.

Nah, I think it's fine like this

@madsmtm madsmtm merged commit f5c6914 into rust-windowing:master Dec 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DS - appkit Affects the AppKit/macOS backend

Development

Successfully merging this pull request may close these issues.

2 participants