Merge Window::set_cursor_icon() and Window::set_custom_cursor()#3308
Merged
daxpedda merged 1 commit intorust-windowing:masterfrom Dec 25, 2023
Merged
Merge Window::set_cursor_icon() and Window::set_custom_cursor()#3308daxpedda merged 1 commit intorust-windowing:masterfrom
Window::set_cursor_icon() and Window::set_custom_cursor()#3308daxpedda merged 1 commit intorust-windowing:masterfrom
Conversation
e8095de to
b18cf41
Compare
b18cf41 to
5c24946
Compare
madsmtm
approved these changes
Dec 25, 2023
5c24946 to
b40441e
Compare
b40441e to
4eb8b69
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This merges the two methods
Window::set_cursor_icon()andWindow::set_custom_cursor().The underlying implementations were not changed at all!
This simplifies the API a bit so we don't have two methods that override each other, in the future this will allow a getter to be implemented when Linux implements caching, see #3306.
In a follow-up I will implement a custom cursor setting in
WindowBuilder, the merged type allowsWindowAttributesto easily expose the currently set cursor.