Skip to content

Remove generic parameter T from EventLoopWindowTarget#3298

Merged
madsmtm merged 1 commit intomasterfrom
windowtarget-no-generic
Jan 13, 2024
Merged

Remove generic parameter T from EventLoopWindowTarget#3298
madsmtm merged 1 commit intomasterfrom
windowtarget-no-generic

Conversation

@madsmtm
Copy link
Copy Markdown
Member

@madsmtm madsmtm commented Dec 24, 2023 •
edited
Loading

Fixes #3053.

Blocked on #3061.

  • Tested on all platforms changed
  • Added an entry to CHANGELOG.md if knowledge of this change could be valuable to users
  • Updated documentation to reflect any user-facing changes, including notes of platform-specific behavior
  • Created or updated an example program if it would help users understand this functionality
  • Updated feature matrix, if new features were added or implemented

@madsmtm madsmtm added S - api Design and usability S - maintenance Repaying technical debt labels Dec 24, 2023
@madsmtm madsmtm mentioned this pull request Dec 24, 2023
Closed
9 tasks
@madsmtm madsmtm force-pushed the windowtarget-no-generic branch from 44aa4ad to 3b06f64 Compare December 24, 2023 00:53
@madsmtm madsmtm mentioned this pull request Dec 24, 2023
Closed
5 tasks
@madsmtm madsmtm force-pushed the windowtarget-no-generic branch 2 times, most recently from 7466225 to 23a3e09 Compare January 4, 2024 16:00
@madsmtm madsmtm marked this pull request as ready for review January 4, 2024 16:02
daxpedda
daxpedda approved these changes Jan 4, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@daxpedda daxpedda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cross-platform stuff and Web looks great!
Thank you @madsmtm for getting this done!

@madsmtm madsmtm force-pushed the windowtarget-no-generic branch 2 times, most recently from 01bbc04 to 149d14f Compare January 13, 2024 20:26
@madsmtm madsmtm force-pushed the windowtarget-no-generic branch from 149d14f to 24e7b0e Compare January 13, 2024 20:30
@madsmtm madsmtm merged commit 2231180 into master Jan 13, 2024
@madsmtm madsmtm deleted the windowtarget-no-generic branch January 13, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daxpedda daxpedda daxpedda approved these changes

@kchibisov kchibisov Awaiting requested review from kchibisov

Assignees

No one assigned

Labels

S - api Design and usability S - maintenance Repaying technical debt

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Make EventLoopWindowTarget<T> independent of the user event type T

2 participants

@madsmtm @daxpedda