Rename Window::set_inner_size to Window::request_inner_size#2930
Rename Window::set_inner_size to Window::request_inner_size#2930kchibisov merged 2 commits intorust-windowing:masterfrom
Window::set_inner_size to Window::request_inner_size#2930Conversation
|
Implementation on some platforms may not represent the actual state of things, I'd suggest to ensure at least |
|
Should a I would say yes. |
it's up to backend though. If server won't sent a new size it's up to it. Nothing we can do here to be fair. |
On Web we can just request it. |
daxpedda
left a comment
There was a problem hiding this comment.
Web is correct like this, nothing more to be done here except the ongoing discussion about triggering the event if nothing changed.
Some systems could resize the window immediately and we'd rather inform the users right away if that was the case, so they could create e.g. EGLSurface without waiting for resize, which is really important for Wayland. Fixes rust-windowing#2868.
Co-authored-by: Markus Siglreithmaier <m.siglreith@gmail.com>
103db54 to
91f1794
Compare
Some systems could resize the window immediately and we'd rather inform the users right away if that was the case, so they could create e.g. EGLSurface without waiting for resize, which is really important for Wayland.
Fixes #2868.
CHANGELOG.mdif knowledge of this change could be valuable to users