Allow recreating wasm event loop with spawn#2897
Merged
daxpedda merged 1 commit intorust-windowing:masterfrom Jun 23, 2023
Merged
Allow recreating wasm event loop with spawn#2897daxpedda merged 1 commit intorust-windowing:masterfrom
spawn#2897daxpedda merged 1 commit intorust-windowing:masterfrom
Conversation
daxpedda
approved these changes
Jun 22, 2023
Member
daxpedda
left a comment
There was a problem hiding this comment.
LGTM!
You said you still wanted to test this in detail, so I'm gonna hold off merging this until you are ready.
Contributor
Author
|
@daxpedda confirmed that it allows me to recreate the event loop, so this should be ready |
628be54 to
6e45230
Compare
Contributor
Author
|
Rebased again for the changelog conflict |
daxpedda
approved these changes
Jun 23, 2023
6e45230 to
9d86c7c
Compare
Contributor
Author
|
@daxpedda thanks! Rebased |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebased #2720
CHANGELOG.mdif knowledge of this change could be valuable to usersIt seems to work after rebasing but haven't been able to test in detail yet. It looks like some other recent winit changes broke my canvas sizing so I need to look into that.