Bring OptionAsAlt back for macOS#2887
Merged
kchibisov merged 1 commit intorust-windowing:masterfrom Jun 20, 2023
Merged
Conversation
|
@kchibisov. I think we will try this after it is merged to master. And probably also after the PR I'm working on in Neovide is merged to avoid potentially breaking stuff that has already been tested there. I also need to rely on other people doing the testing, since I don't own a Mac. |
This was referenced Jun 20, 2023
Closed
madsmtm
approved these changes
Jun 20, 2023
The correct handling of this setting requires to change the events we're getting from the macOS on the fly and call `interpretKeyEvents`, which could affect handling of the next events, meaning that we can't provide them on `KeyEvent`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The correct handling of this setting requires to change the events we're getting from the macOS on the fly and call
interpretKeyEvents, which could affect handling of the next events, meaning that we can't provide them onKeyEvent.--
This is basically old option we had with winit
0.28.0.cc @fredizzimo if you want to try it with neovide.