Add Window::is_minimized#2626
Merged
kchibisov merged 12 commits intorust-windowing:masterfrom Jan 19, 2023
Merged
Conversation
kchibisov
reviewed
Jan 15, 2023
kchibisov
reviewed
Jan 15, 2023
kchibisov
requested changes
Jan 15, 2023
Member
kchibisov
left a comment
There was a problem hiding this comment.
The change is ok. But would need to return Option given that some platforms don't provide a way to know whether the window is minimized or not.
Contributor
Author
I am fine with that but I should note that there is other similar functions that return only bools, like |
Member
|
It's not about support though. It's about 'you can't possibly know' that you're minimized or not. With maximized/resizable you surely know such a thing. |
Contributor
Author
|
yeah, makes a bit of sense. |
kchibisov
requested changes
Jan 17, 2023
c3692d1 to
a63f25c
Compare
kchibisov
reviewed
Jan 18, 2023
Co-authored-by: Kirill Chibisov <contact@kchibisov.com>
msiglreith
reviewed
Jan 18, 2023
Co-authored-by: Markus Siglreithmaier <m.siglreith@gmail.com>
Co-authored-by: Markus Siglreithmaier <m.siglreith@gmail.com>
kchibisov
approved these changes
Jan 19, 2023
jackpot51
approved these changes
Jan 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGELOG.mdif knowledge of this change could be valuable to users