wayland: internal event buffer & wait for xdg configure#255
Merged
tomaka merged 1 commit intorust-windowing:masterfrom Aug 31, 2017
Merged
wayland: internal event buffer & wait for xdg configure#255tomaka merged 1 commit intorust-windowing:masterfrom
tomaka merged 1 commit intorust-windowing:masterfrom
Conversation
Contributor
|
Triage. I guess there's no reason not to merge this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does three things:
Window::new()may be blockingWindowEvent::Refreshin this internal buffer whenever a window is created, this guarantees the event loop will have something to dispatch when first started, and should solve for good any issue of deadlock of the event loop as previously saw with wayland (without that, the multiwindow example of glutin still deadlocked)wayland_windowdependency, which provides a better handling of said configure event