Fix menubar focus using Alt on Windows#2521
Merged
msiglreith merged 1 commit intorust-windowing:masterfrom Oct 20, 2022
Merged
Conversation
msiglreith
approved these changes
Oct 20, 2022
Member
msiglreith
left a comment
There was a problem hiding this comment.
thanks, looks reasonable to mirror the WS_SYSKEYDOWN part
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGELOG.mdif knowledge of this change could be valuable to usersI am not sure if this is the right fix or not because I am not familiar with the keyboard handling in winit and win32 in general and I actually found this fix by trial and error with keyboard related handling branches.
winit@92fdf5ba
PR@985000e1
