On X11, fix IME crashing without available styles#2512
Merged
kchibisov merged 1 commit intorust-windowing:masterfrom Oct 9, 2022
Merged
On X11, fix IME crashing without available styles#2512kchibisov merged 1 commit intorust-windowing:masterfrom
kchibisov merged 1 commit intorust-windowing:masterfrom
Conversation
During reload we were picking old styles, but the styles could change during reload leading to errors during IME building. Fixes rust-windowing#2510.
Member
Author
|
Patch was tested here alacritty/alacritty#6370 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2510.
CHANGELOG.mdif knowledge of this change could be valuable to users--
I can't repro the initial issue in the first place though and it doesn't make any sense, but it was bisected to the recent change.