Skip to content

Implement requestAnimationFrame for web#1519

Merged
ryanisaacg merged 4 commits intorust-windowing:masterfrom
chemicstry:animation_callback2
Apr 11, 2020
Merged

Implement requestAnimationFrame for web#1519
ryanisaacg merged 4 commits intorust-windowing:masterfrom
chemicstry:animation_callback2

Conversation

@chemicstry
Copy link
Copy Markdown
Contributor

@chemicstry chemicstry commented Mar 27, 2020

  • Tested on all platforms changed
  • Compilation warnings were addressed
  • cargo fmt has been run on this branch
  • cargo doc builds successfully
  • Added an entry to CHANGELOG.md if knowledge of this change could be valuable to users
  • Updated documentation to reflect any user-facing changes, including notes of platform-specific behavior
  • Created or updated an example program if it would help users understand this functionality
  • Updated feature matrix, if new features were added or implemented

Implementation based on discussion in #1493. I did not implement requestPostAnimationFrame because it's not documented properly yet and does not exist in stdweb or web_sys either.

@chemicstry chemicstry force-pushed the animation_callback2 branch from 1cf674a to b104525 Compare March 27, 2020 23:48
@chemicstry chemicstry force-pushed the animation_callback2 branch from b104525 to e7fb852 Compare March 27, 2020 23:49
@chemicstry
Copy link
Copy Markdown
Contributor Author

chemicstry commented Mar 29, 2020

Not sure why windows CI failed (can someone rerun?), but otherwise this is ready for review

@azriel91 azriel91 mentioned this pull request Apr 5, 2020
Closed
ryanisaacg
ryanisaacg approved these changes Apr 6, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@ryanisaacg ryanisaacg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I had the same (presumably spurious) Windows CI failure in #1512. This has re-ignited me to try to get it fixed, so we can land both of these changes.

@ryanisaacg ryanisaacg added DS - web Affects the Web backend (WebAssembly/WASM) P - high Vital to have S - enhancement Wouldn't this be the coolest? labels Apr 6, 2020
@ryanisaacg
Copy link
Copy Markdown
Contributor

ryanisaacg commented Apr 11, 2020

Ok, got CI to pass. Thanks again!

@ryanisaacg ryanisaacg merged commit 1f24a09 into rust-windowing:master Apr 11, 2020
@Osspial Osspial mentioned this pull request Apr 20, 2020
Closed
@daxpedda daxpedda mentioned this pull request Jun 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ryanisaacg ryanisaacg ryanisaacg approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

DS - web Affects the Web backend (WebAssembly/WASM) P - high Vital to have S - enhancement Wouldn't this be the coolest?

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@chemicstry @ryanisaacg