Skip to content

Implement windows focus key press/release on Windows #1307

Merged
Osspial merged 3 commits intorust-windowing:masterfrom
Osspial:windows-focus-keys
Dec 27, 2019
Merged

Implement windows focus key press/release on Windows #1307
Osspial merged 3 commits intorust-windowing:masterfrom
Osspial:windows-focus-keys

Conversation

@Osspial
Copy link
Copy Markdown
Contributor

@Osspial Osspial commented Dec 4, 2019

  • Tested on all platforms changed
  • Compilation warnings were addressed
  • cargo fmt has been run on this branch
  • cargo doc builds successfully
  • Added an entry to CHANGELOG.md if knowledge of this change could be valuable to users

Implements #1272 on Windows.

@goddessfreya goddessfreya added DS - win32 Affects the Win32/Windows backend C - waiting on author Waiting for a response or another PR labels Dec 4, 2019
@Osspial Osspial marked this pull request as ready for review December 22, 2019 06:31
murarth and others added 3 commits December 22, 2019 01:32
* When a window loses focus, key release events are issued for all pressed keys
* When a window gains focus, key press events are issued for all pressed keys
* Adds `is_synthetic` field to `WindowEvent` variant `KeyboardInput`
  to indicate that these events are synthetic.
* Adds `is_synthetic: false` to `WindowEvent::KeyboardInput` events issued
  on all other platforms
@goddessfreya goddessfreya added C - waiting on maintainer A maintainer must review this code and removed C - waiting on author Waiting for a response or another PR labels Dec 22, 2019
@Osspial Osspial merged commit cc206d3 into rust-windowing:master Dec 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C - waiting on maintainer A maintainer must review this code DS - win32 Affects the Win32/Windows backend

Development

Successfully merging this pull request may close these issues.

3 participants