Skip to content

Replace set_decorations with set_prefers_status_bar_hidden on iOS#1092

Merged
goddessfreya merged 3 commits intomasterfrom
unknown repository
Aug 8, 2019
Merged

Replace set_decorations with set_prefers_status_bar_hidden on iOS#1092
goddessfreya merged 3 commits intomasterfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Aug 4, 2019

I don't think the semantics of set_decorations really match with the intent of wanting to hide the status bar. On desktop platforms for example, fullscreen windows are expected to automatically get their decorations disabled. On iOS however, all windows are fullscreen but the status bar is still enabled by default. It's also a common use case to have a regular windowed application (with decorations!) on desktop platforms, but to also hide the status bar on iOS. It looks confusing to have the set_decorations call be only invoked for iOS. This pull request makes set_decorations a no-op on iOS and adds a new extension function set_prefers_status_bar_hidden to WindowExtIOS and with_prefers_status_bar_hidden to WindowBuilderExtIOS.

  • Tested on all platforms changed
  • Compilation warnings were addressed
  • cargo fmt has been run on this branch
  • Added an entry to CHANGELOG.md if knowledge of this change could be valuable to users
  • Updated documentation to reflect any user-facing changes, including notes of platform-specific behavior
  • Created or updated an example program if it would help users understand this functionality
  • Updated feature matrix, if new features were added or implemented

@mtak-
Copy link
Copy Markdown
Contributor

mtak- commented Aug 5, 2019

Loving all these iOS PRs!

Mind updating the feature matrix to replace the ✔️'s in window decorations with **N/A**, and adding a note about hiding the status bar to the ### iOS section?

The platform specific docs for set_decorations should also be removed.

Thanks!

@ghost
Copy link
Copy Markdown
Author

ghost commented Aug 6, 2019

Thank you! I've now updated the documentation appropriately.

@goddessfreya goddessfreya merged commit 30b4f8d into rust-windowing:master Aug 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants