Replace set_decorations with set_prefers_status_bar_hidden on iOS#1092
Merged
goddessfreya merged 3 commits intomasterfrom Aug 8, 2019
unknown repository
Merged
Replace set_decorations with set_prefers_status_bar_hidden on iOS#1092goddessfreya merged 3 commits intomasterfrom unknown repository
set_decorations with set_prefers_status_bar_hidden on iOS#1092goddessfreya merged 3 commits intomasterfrom
unknown repository
Conversation
Contributor
|
Loving all these iOS PRs! Mind updating the feature matrix to replace the ✔️'s in window decorations with The platform specific docs for Thanks! |
Author
|
Thank you! I've now updated the documentation appropriately. |
mtak-
approved these changes
Aug 6, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't think the semantics of
set_decorationsreally match with the intent of wanting to hide the status bar. On desktop platforms for example, fullscreen windows are expected to automatically get their decorations disabled. On iOS however, all windows are fullscreen but the status bar is still enabled by default. It's also a common use case to have a regular windowed application (with decorations!) on desktop platforms, but to also hide the status bar on iOS. It looks confusing to have theset_decorationscall be only invoked for iOS. This pull request makesset_decorationsa no-op on iOS and adds a new extension functionset_prefers_status_bar_hiddentoWindowExtIOSandwith_prefers_status_bar_hiddentoWindowBuilderExtIOS.cargo fmthas been run on this branchCHANGELOG.mdif knowledge of this change could be valuable to users