Stop appending canvas to document in web platform#1089
Merged
goddessfreya merged 3 commits intorust-windowing:webfrom Aug 8, 2019
Merged
Stop appending canvas to document in web platform#1089goddessfreya merged 3 commits intorust-windowing:webfrom
goddessfreya merged 3 commits intorust-windowing:webfrom
Conversation
ryanisaacg
approved these changes
Aug 3, 2019
Contributor
|
lgtm, merging, thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changes here stop
winitfrom automatically appending the window canvas to the document root in the web platform. I discussed this with @ryanisaacg on Discord and we seemed to agree.I think this approach has multiple benefits:
winitto simply providing a canvas with the proper event listeners attached.winit's scope, like changing the document/tab title or updating the favicon. The user is expected to implement this on top ofwinitif necessary.Additionally, I have updated an unnecessary
TODOcomment and fixed some panics on canvas creation.