Do not require T: Clone for EventLoopProxy<T>: Clone#1086
Merged
Osspial merged 5 commits intorust-windowing:masterfrom Aug 5, 2019
yvt:patch-clone-proxy
Merged
Do not require T: Clone for EventLoopProxy<T>: Clone#1086Osspial merged 5 commits intorust-windowing:masterfrom yvt:patch-clone-proxy
T: Clone for EventLoopProxy<T>: Clone#1086Osspial merged 5 commits intorust-windowing:masterfrom
yvt:patch-clone-proxy
Conversation
Contributor
|
Needs a changelog entry, then lgtm. (Assuming it builds) |
9 tasks
Contributor
Author
|
I accidentally tested the wrong branch (my bad!). It should be okay now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request removes the
T: Clonerestriction from theCloneimpl ofEventLoopProxy<T>.cargo fmthas been run on this branchCHANGELOG.mdif knowledge of this change could be valuable to users