Skip to content

Fix armv7-apple-ios compile target#1083

Merged
goddessfreya merged 1 commit intomasterfrom
unknown repository
Aug 1, 2019
Merged

Fix armv7-apple-ios compile target#1083
goddessfreya merged 1 commit intomasterfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Jul 31, 2019

  • Tested on all platforms changed
  • Compilation warnings were addressed
  • cargo fmt has been run on this branch
  • Added an entry to CHANGELOG.md if knowledge of this change could be valuable to users
  • Updated documentation to reflect any user-facing changes, including notes of platform-specific behavior
  • Created or updated an example program if it would help users understand this functionality
  • Updated feature matrix, if new features were added or implemented

@goddessfreya
Copy link
Copy Markdown
Contributor

Shouldn't we also be testing x86_64-apple-ios?

@ghost
Copy link
Copy Markdown
Author

ghost commented Jul 31, 2019

Sure! I believe it's only used for the Simulator. I dropped it initially because I was worried it would inflate the build times for Travis, but it looks like it's so fast that it doesn't even matter. I'll add it back.

@ghost
Copy link
Copy Markdown
Author

ghost commented Aug 1, 2019

Should be all good now!

@goddessfreya goddessfreya merged commit 1e4c176 into rust-windowing:master Aug 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants