Rename new_user_event to with_user_event#1068
Merged
goddessfreya merged 1 commit intorust-windowing:masterfrom Jul 29, 2019
Merged
Rename new_user_event to with_user_event#1068goddessfreya merged 1 commit intorust-windowing:masterfrom
new_user_event to with_user_event#1068goddessfreya merged 1 commit intorust-windowing:masterfrom
Conversation
new_user_event to new_with_user_event (#1057)new_user_event to new_with_user_event
Contributor
c1c7947 to
797d82a
Compare
Contributor
Author
|
I think I had misinterpreted the comment but updated the method name correctly now. |
Contributor
|
Thanks for implementing this! All we need is a changelog entry and this should be good to merge. |
new_user_event to new_with_user_eventnew_user_event to with_user_event
797d82a to
63e1db6
Compare
Contributor
Author
|
All done updating the CHANGELOG. |
Contributor
|
Can you try re-pushing? Appveyor seams angry. |
b1786bb to
fbf2fc0
Compare
fbf2fc0 to
d03d706
Compare
Contributor
Author
|
Looks better now. 😃 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finishes #1057
cargo fmthas been run on this branchCHANGELOG.mdif knowledge of this change could be valuable to users