Skip to content

PULL_REQUEST_TEMPLATE.md: Add entry on warnings#1017

Merged
goddessfreya merged 1 commit intorust-windowing:masterfrom
felixrabe:pull-req-1
Jul 26, 2019
Merged

PULL_REQUEST_TEMPLATE.md: Add entry on warnings#1017
goddessfreya merged 1 commit intorust-windowing:masterfrom
felixrabe:pull-req-1

Conversation

@felixrabe
Copy link
Copy Markdown
Contributor

No description provided.

@Osspial
Copy link
Copy Markdown
Contributor

Osspial commented Jul 6, 2019

We should also add -D warnings to the CI so it fails in case of warnings.

@rukai
Copy link
Copy Markdown
Contributor

rukai commented Jul 7, 2019

Uh, the page you linked to explains why that is bad idea...

@felixrabe
Copy link
Copy Markdown
Contributor Author

felixrabe commented Jul 7, 2019

I'll test the CI setup in this PR (cause I'm new to CI configuration), then force-revert, and then open a new PR so we can discuss this separately.

Don't merge yet.

@felixrabe felixrabe mentioned this pull request Jul 7, 2019
2 tasks
@felixrabe
Copy link
Copy Markdown
Contributor Author

felixrabe commented Jul 7, 2019

Tests successful – my CI configuration changes should work as expected. I've force-reverted back to the initial commit, so this PR is ready to merge again.

The CI configuration change can be found in my branch ci-config-1 which builds on this PR.

(I'm not going to fix the mem::uninitialized() deprecation warnings right now, hoping someone else beats me to it. See #1025.)

@Osspial
Copy link
Copy Markdown
Contributor

Osspial commented Jul 7, 2019

@rukai Hmm, probably should've done more than just skim that article.

We could do -D warnings -A deprecated. I'm fairly OK with Travis catching warnings for compiler mis-features, since we'd want to fix those ASAP.

@felixrabe
Copy link
Copy Markdown
Contributor Author

felixrabe commented Jul 7, 2019

I think mem::uninitialized() should be easy to fix (see #1025), and I don't think we have other outstanding warnings (besides my warnings PR #1020), so -A deprecated is not needed.

@Osspial
Copy link
Copy Markdown
Contributor

Osspial commented Jul 7, 2019

@felixrabe The -A deprecated is mainly for future-proofing PRs so they don't fail unnecessarily, since there's a decent chance we're using APIs internally that will get deprecated sometime in the future.

@goddessfreya goddessfreya merged commit 4ae9900 into rust-windowing:master Jul 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants