-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Don't panic :) #971
Copy link
Copy link
Open
Labels
C - needs discussionDirection must be ironed outDirection must be ironed outS - apiDesign and usabilityDesign and usabilityS - metaProject governanceProject governance
Description
I think there is too much unwrap in winit and it could benefit from a healty dose of Results. Thus I'm opening this issue to spark discussion on:
- Is such a change desirable? (I vote "yes".)
- To people knowing more about winit internals: Is it feasible? (If we can only get rid of panics in half the places, it might be more confusing to users than just a "catch the panic if you care" policy.)
- If yes, start a PR converting a handful of currently non-Result-returning functions to return
Result. (/me volunteers.) - Decide on when to release this. Seems to make sense to not include this change in 0.20, but maybe 0.21?
- Pretty please use the codename "Don't panic :)" for that release. :)
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
C - needs discussionDirection must be ironed outDirection must be ironed outS - apiDesign and usabilityDesign and usabilityS - metaProject governanceProject governance