Skip to content

Don't panic :) #971

@felixrabe

Description

@felixrabe

I think there is too much unwrap in winit and it could benefit from a healty dose of Results. Thus I'm opening this issue to spark discussion on:

  • Is such a change desirable? (I vote "yes".)
  • To people knowing more about winit internals: Is it feasible? (If we can only get rid of panics in half the places, it might be more confusing to users than just a "catch the panic if you care" policy.)
  • If yes, start a PR converting a handful of currently non-Result-returning functions to return Result. (/me volunteers.)
  • Decide on when to release this. Seems to make sense to not include this change in 0.20, but maybe 0.21?
  • Pretty please use the codename "Don't panic :)" for that release. :)

Original discussion.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions