Skip to content

Type errors in unix::WindowExt for X11 #256

@elinorbgr

Description

@elinorbgr

The get_xlib_window returns a value that is defined by the X11 API to be Wffi::indow (which is a typedef to c_ulong), but casts it to *mut c_void.

Likewise, get_xlib_screen_id returns a value defined by the X11 API to be a c_int, but casts it to *mut c_void.

My understanding of the X11 API is very light, but this seems wrong to do so, especially given depending on the architecture, these types are not guaranteed to even be the same size.

Do you have some insight regarding this @Ralith ? (pinging you as you seem to have a fair amount of knowledge of X11)

Metadata

Metadata

Assignees

No one assigned

    Labels

    DS - x11Affects the X11 backend, or generally free Unix platforms

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions