Mac: Redraw immediately to prevent shaking on window resize (#1901)

xiaopengli89 · maroider · web-flow · commit ba704c4eb496 · 2021-04-06T09:22:38.000+02:00
* Mac: Redraw immediately to prevent shaking on window resize

* Update CHANGELOG.md

* Update CHANGELOG.md

Co-authored-by: 李小鹏 &lt;lixiaopeng.jetspark@bytedance.com&gt;
Co-authored-by: Markus Røyset &lt;maroider@protonmail.com&gt;
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -19,6 +19,7 @@
 - Added `WindowBuilder::with_position` to allow setting the position of a `Window` on creation. Supported on Windows, macOS and X11.
 - Added `Window::drag_window`. Implemented on Windows, macOS, X11 and Wayland.
 - On X11, bump `mio` to 0.7.
+- On macOS, emit `RedrawRequested` events immediately while the window is being resized.
 
 # 0.24.0 (2020-12-09)
 
diff --git a/src/platform_impl/macos/app_state.rs b/src/platform_impl/macos/app_state.rs
@@ -327,6 +327,10 @@ impl AppState {
         }
     }
 
+    pub fn handle_redraw(window_id: WindowId) {
+        HANDLER.handle_nonuser_event(EventWrapper::StaticEvent(Event::RedrawRequested(window_id)));
+    }
+
     pub fn queue_event(wrapper: EventWrapper) {
         if !unsafe { msg_send![class!(NSThread), isMainThread] } {
             panic!("Event queued from different thread: {:#?}", wrapper);
diff --git a/src/platform_impl/macos/view.rs b/src/platform_impl/macos/view.rs
@@ -346,7 +346,7 @@ extern "C" fn draw_rect(this: &Object, _sel: Sel, rect: NSRect) {
         let state_ptr: *mut c_void = *this.get_ivar("winitState");
         let state = &mut *(state_ptr as *mut ViewState);
 
-        AppState::queue_redraw(WindowId(get_window_id(state.ns_window)));
+        AppState::handle_redraw(WindowId(get_window_id(state.ns_window)));
 
         let superclass = util::superclass(this);
         let () = msg_send![super(this, superclass), drawRect: rect];

Original file line number	Diff line number	Diff line change
`@@ -327,6 +327,10 @@ impl AppState {`
`327`	`327`	`}`
`328`	`328`	`}`
`329`	`329`
	`330`	`+ pub fn handle_redraw(window_id: WindowId) {`
	`331`	`+ HANDLER.handle_nonuser_event(EventWrapper::StaticEvent(Event::RedrawRequested(window_id)));`
	`332`	`+ }`
	`333`	`+`
`330`	`334`	`pub fn queue_event(wrapper: EventWrapper) {`
`331`	`335`	`if !unsafe { msg_send![class!(NSThread), isMainThread] } {`
`332`	`336`	`panic!("Event queued from different thread: {:#?}", wrapper);`