examples/winit: Implement proper resumed() semantics#127
examples/winit: Implement proper resumed() semantics#127MarijnS95 merged 2 commits intorust-windowing:masterfrom
resumed() semantics#127Conversation
e3d086e to
6b0083a
Compare
|
This was done as a part of #214, so I'll close this PR |
|
I see, thanks for letting me know. |
|
@notgull I've force-pushed a rework of this patch (based on top of #227), let me know what you think before I convert the remaining examples and make a PR. Note that there is some confusion currently in the |
This comment was marked as outdated.
This comment was marked as outdated.
bc0a66a to
592c49e
Compare
Event::Resumed semanticsresumed() semantics
|
EDIT: Never mind this. The |
daxpedda
left a comment
There was a problem hiding this comment.
LGTM!
CI is broken because of the changes in WinitApp right?
daxpedda
left a comment
There was a problem hiding this comment.
LGTM!
Would like to replace (e)print(ln) with tracing, but that's for a follow-up.
Documentation tests have to be fixed.
|
@MarijnS95 rebasing on #228 should fix the remaining CI. |
c1162bf to
ae7f947
Compare
ae7f947 to
0f708dd
Compare
0f708dd to
41cd8cd
Compare
41cd8cd to
d1f73bc
Compare
|
Only nightly seems to fail on |
6173ad8 to
cb5d125
Compare
|
Yikes, this relative path error, that we first only saw on Did the fix (assuming it is a fix to how relative paths from content in After all, I'd argue the path should be relative to Pushed a "fix", let's see if nightly would then start to break again... |
cb5d125 to
6536da3
Compare
On Android the backing buffer (`NativeWindow`) disappears when the application is not focussed and/or the screen is locked. Winit handles this by requiring apps to create their `raw_window_handle()` consumers _after_ `Event::Resumed` and to clean it up _before_ returning from `Event::Suspended`. For consistency Winit also sends `Resumed` on all other platforms during init.
6536da3 to
de4586d
Compare
On Android the backing buffer (
NativeWindow) disappears when the application is not focussed and/or the screen is locked. Winit handles this by requiring apps to create theirraw_window_handle()consumers afterEvent::Resumedand to clean it up before returning fromEvent::Suspended. For consistency Winit also sendsResumedon all other platforms during init.Draft until this is transplanted to all the other examples, even though that doesn't magically make them run on Android yet.