add TrustedHandle type#52
Merged
Osspial merged 3 commits intorust-windowing:masterfrom Jul 31, 2020
Lokathor:trusted-handle
Merged
add TrustedHandle type#52Osspial merged 3 commits intorust-windowing:masterfrom Lokathor:trusted-handle
Osspial merged 3 commits intorust-windowing:masterfrom
Lokathor:trusted-handle
Conversation
Osspial
suggested changes
Jul 31, 2020
Contributor
Osspial
left a comment
There was a problem hiding this comment.
This mostly looks good to me, but I'd prefer the name TrustedWindowHandle.
Osspial
approved these changes
Jul 31, 2020
|
Would it be possible to have a safe impl of Specifically, an implementation which would replace https://github.com/bevyengine/bevy/blob/a68c78cef5fb2112617de095efd4e64cba1587eb/crates/bevy_winit/src/winit_windows.rs#L117-L119 (I need this for bevyengine/bevy#1279, which is currently assuming that the impl could be correct, so I would like to know if that assumption is wrong anyway. That PR is otherwise blocked on #58 anyway) |
Contributor
Author
|
Could you open this as a new issue where I won't lose track of it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a wrapper to mark when a specific raw window handle is to be trusted.
Closes #49