Merged
Conversation
This is a breaking change
Lokathor
approved these changes
Jun 22, 2023
Contributor
Lokathor
left a comment
There was a problem hiding this comment.
I'm not an android expert but if we added this just for them and we don't need it anymore then it's fine to remove.
Closed
MarijnS95
approved these changes
Jun 23, 2023
Member
MarijnS95
left a comment
There was a problem hiding this comment.
Agreed on the idea and justification, haven't reviewed if this is all the active code/comments though but you know better :)
|
|
||
| * **Breaking:** `HasRaw(Display/Window)Handle::raw_(display/window)_handle` returns a result indicating if fetching the window handle failed (#122). | ||
| * Remove Android-specific platform differences (#118). | ||
| * **Breaking:** Remove the `Active/ActiveHandle` types from the public API (#123). |
Member
There was a problem hiding this comment.
Suggested change
| * **Breaking:** Remove the `Active/ActiveHandle` types from the public API (#123). | |
| * **Breaking:** Remove the `Active/ActiveHandle` types from the public API (#126). |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since it's unnecessary and #122 is a breaking change anyways.