Restrict compilation of borrowed handles on Android#117
Merged
Conversation
Contributor
|
it's smoothest if we just turn this on for everyone without the cargo feature, since we'd only remove the cargo feature later. This way, the only people affected are android builders with no_std (who i suspect are very rare). |
Lokathor
approved these changes
Mar 30, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Guards borrowed handles behind either
stdor not being on Android. Should prevent this from being a breaking change.Another possible way around this would be to add a
borrowedfeature.