Don't use wayland_client specific types in winit's API.#893
Merged
tomaka merged 1 commit intorust-windowing:masterfrom May 31, 2017
Merged
Don't use wayland_client specific types in winit's API.#893tomaka merged 1 commit intorust-windowing:masterfrom
tomaka merged 1 commit intorust-windowing:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Given the recent changes in wayland-client, this strongly-typed interface between winit and glutin regarding wayland types is not needed anymore.
This PR effectively removes the need for winit to expose wayland-client's types, as glutin will not depend on them anymore.
Effectively removing them from winit will however likely require a breaking version bump from winit (as older versions of glutin still will depend on it), so we'll probably be able to do it next time such a bump occurs.