Handle android activity life cycle and event loop#868
Handle android activity life cycle and event loop#868tomaka merged 1 commit intorust-windowing:masterfrom
Conversation
1154d3e to
e07a7a6
Compare
e07a7a6 to
f9568cc
Compare
f9568cc to
8532ab4
Compare
|
I did a rebase and adapted the code to the new EventLoop API |
|
@tomaka I see that the API has changed and EventLoop has been moved to winit. Now I can't create the EventLoop override to handle EGL life cycle events on Android:
We need the android life cycle merged to unfork glutin in Servo. What's the best way to do this now? |
|
Err I knew there would be a quirk with exposing winit. |
|
I thought a bit about this, and considered the following solutions:
But in the end I think the best thing to do is make a tweak to the winit's The solution would be specific to Android (with a trait hidden with |
|
Yes, I though doing a similar thing too but with all events. Doing with suspend event only is ok. I don't think that we'll need to handle other events directly in Glutin. |
|
@tomaka Is what you describe here #868 (comment) still the approach you recommend? |
|
@paulrouget The discussion has more or less moved there: rust-windowing/winit#231 |
8532ab4 to
a6519eb
Compare
|
@MortimerGoro winit 0.11.1 has been published. |
a6519eb to
8695baa
Compare
|
@paulrouget thanks for the notfication. PR updated! @tomaka We need to update winit dependency from 10.x to 11.x here. Do you want a separate PR for that change? |
|
@MortimerGoro Yes please. |
8ab7897 to
7507ce2
Compare
7507ce2 to
88634ec
Compare
|
@tomaka r? PR ready |
|
Thanks, looks good except for a few style issues. |
Handle android activity life cycle and event loop
Related PR: rust-windowing/winit#153