Make display, surface and context creation safe#1582
Make display, surface and context creation safe#1582notgull wants to merge 1 commit intorust-windowing:masterfrom
Conversation
|
Hmm, looks like this model kind of breaks A solution would be to use an |
8a7648b to
ab86b25
Compare
b4bbf3a to
bcf2996
Compare
|
Rebased around rust-windowing/raw-window-handle#125, aka |
ab3947a to
1e75b95
Compare
|
Rebased on the newest master |
|
The main caveat is that the |
Support for GLX Partial EGL support Finish out full glutin implementation Port over aux. crates Fix doctests Fix eminent compile errors Signed-off-by: John Nunley <dev@notgull.net> Update CHANGELOG.md Signed-off-by: John Nunley <dev@notgull.net> Add accessors for display and window Signed-off-by: John Nunley <dev@notgull.net>
82da103 to
967f3f4
Compare
|
Any chance for a glutin release with |
|
I'm not sure how soon, since I don't have time to review the glutin stuff now. it's not like you can't use it at all if you have only raw-window-handle 0.6, since you can convert 0.6 to 0.5 and e.g. winit provides all 3 of them at the same time, so you can pick 0.5 for glutin and 0.6 for other winit stuff. But it'll be review/merge within a month... |
|
Ah, winit supports all three of them at the same time, I didn't realize that (thought I had to pick one). Then I can probably figure something out. Thanks for the pointer! EDIT: actually, juggling several rwh-versions is a nightmare. |
|
@emilk what makes you juggle multiple versions, instead of locking winit to 0.5 and using that in glutin? |
|
|
|
Right, that is indeed a painful situation. |
|
Don't really feel like rebasing this and it's unlikely to be reviewed, so I'll abandon this in favor of #1670 |
|
It'll be though, but there's a big chance that I write parts myself. Like I'd like to use safe handles myself, it's just winit is lacking and I said it to you before. Forcing everyone to just start |
CHANGELOG.mdif knowledge of this change could be valuable to usersUses rust-windowing/raw-window-handle#116 to make display, surface and context creation safe.
I want to get a good idea of what this kind of API would look like. I want to test out the new safe window handles before they're released onto the world.