Another try at actually using an nth index cache#164
Merged
cfvescovo merged 1 commit intorust-scraper:masterfrom Dec 26, 2023
adamreichold:nth-index-cache-reuse
Merged
Another try at actually using an nth index cache#164cfvescovo merged 1 commit intorust-scraper:masterfrom adamreichold:nth-index-cache-reuse
cfvescovo merged 1 commit intorust-scraper:masterfrom
adamreichold:nth-index-cache-reuse
Conversation
This re-uses the cache only between the match operations for a single select iteration which ensures that the selector is not dropped (and its allocation address re-used) while the cache is alive thereby avoiding the ABA problem fixed by 7fdac0a. This does not require any change in user code to benefit from the increased caching even though some Debug and Clone implementations need to be done manually now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This re-uses the cache only between the match operations for a single select iteration which ensures that the selector is not dropped (and its allocation address re-used) while the cache is alive thereby avoiding the ABA problem fixed by 7fdac0a.
This does not require any change in user code to benefit from the increased caching even though some Debug and Clone implementations need to be done manually now.