Add trait to abstract over selectable collections of elements#155
Merged
cfvescovo merged 4 commits intorust-scraper:masterfrom Nov 9, 2023
adamreichold:selectable-trait
Merged
Add trait to abstract over selectable collections of elements#155cfvescovo merged 4 commits intorust-scraper:masterfrom adamreichold:selectable-trait
cfvescovo merged 4 commits intorust-scraper:masterfrom
adamreichold:selectable-trait
Conversation
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our codebase contains a simpler version of this trait which we use to write helper functions which can be applied both at the top level to
Htmlbut also if selection is a multi-step process, i.e. toElementRefitself, as the scope to which a CSS selector is applied.Note that this uses generic associated type and hence requires Rust 1.65, c.f. https://blog.rust-lang.org/2022/10/28/gats-stabilization.html.