feat: add clone_subtree method for NodeMut#48
feat: add clone_subtree method for NodeMut#48adamreichold merged 1 commit intorust-scraper:masterfrom
Conversation
e79468c to
6009685
Compare
Is this the only blocker to upgrading our html5ever dependency? If so, could you add that to this pull request? |
6009685 to
1b869f9
Compare
It will be a different PR to scraper crate after a new version of ego_tree is released. |
Yes, of course. Sorry, I was confused as I thought we are in the scraper repository. |
1b869f9 to
060e29f
Compare
adamreichold
left a comment
There was a problem hiding this comment.
Two tiny formatting nits, otherwise, I think the implementation turned out great if somewhat more complex than the initial approach.
Thank you for putting in the extra work!
This is needed to support the new `clone_subtree` method since html5ever 0.37. See <https://docs.rs/html5ever/0.37.1/html5ever/tree_builder/trait.TreeSink.html#tymethod.clone_subtree>.
65f1a12 to
f3e839b
Compare
|
@cfvescovo Could you publish a new patch version to crates.io so that scraper can be moved to html5ever 0.37? Thank you! (I would do so myself, but I do not have access.) |
|
Hi @adamreichold, I apologize for the delay. I will publish it today and give you access to crates.io |
This is needed to support the new
clone_subtreemethod since html5ever 0.37.See https://docs.rs/html5ever/0.37.1/html5ever/tree_builder/trait.TreeSink.html#tymethod.clone_subtree.