Support @ marker in tree! macro to append subtrees#43
Merged
adamreichold merged 2 commits intorust-scraper:masterfrom Feb 9, 2025
Merged
Support @ marker in tree! macro to append subtrees#43adamreichold merged 2 commits intorust-scraper:masterfrom
tree! macro to append subtrees#43adamreichold merged 2 commits intorust-scraper:masterfrom
Conversation
adamreichold
reviewed
Feb 9, 2025
Member
adamreichold
left a comment
There was a problem hiding this comment.
This looks good to me.
I have one tangentially related request though, could you modifiy Tree::extend_tree (backing Tree::append_subtree) to use Vec::append instead of Vec::extend for the possible gain in efficiency? Thanks!
possible efficiency gain
Contributor
Author
|
like that? |
adamreichold
approved these changes
Feb 9, 2025
Member
adamreichold
left a comment
There was a problem hiding this comment.
Yes, exactly. Vec::extend likely does some specialization behind the scenes, but since our API takes ownership of the given subtree, we can use the most specialized API for that directly.
Member
|
Let's leave it open for a bit if anyone else wants to have a look. Otherwise, I'll merge tonight CET. |
Contributor
Author
|
great 😃 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support merging trees in the
tree!macro with the@marker:subtree: a └── b tree: foo ├── bar └── a └── b