Add sort feature for tree NodeMut#41
Merged
cfvescovo merged 2 commits intorust-scraper:masterfrom Dec 9, 2024
Merged
Conversation
adamreichold
reviewed
Dec 8, 2024
adamreichold
reviewed
Dec 8, 2024
adamreichold
reviewed
Dec 8, 2024
2e8ab17 to
204889b
Compare
AuTa
commented
Dec 8, 2024
AuTa
commented
Dec 8, 2024
Contributor
Author
|
In fact, my code sorts the children in each layer but I'm not very good at writing recursion in Rust. 🤦 |
adamreichold
reviewed
Dec 8, 2024
bed9dae to
a2f7f0a
Compare
adamreichold
reviewed
Dec 8, 2024
314ea42 to
5eb4062
Compare
This module provides methods for sorting children of a node in a tree. The sorting can be done based on the node values or their indices.
adamreichold
approved these changes
Dec 8, 2024
Contributor
Author
|
Apologize to the previous |
cfvescovo
approved these changes
Dec 9, 2024
Member
|
LGTM (and to the CI too, now) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This module provides methods for sorting children of a node in a tree.
The sorting can be done based on the node values or their indices.
Resolved #39