Conversation
This patch updates rust-rocksdb to correctly build on Apple Silicon (using all native tools). We include patches to rustdb found here: facebook/rocksdb#7714. Additionally, we upgrade the build script and rocksdb libraries to fix compilation. See issue here: rust-rocksdb#482
dbcfe0f to
e0eac77
Compare
|
BTW, my friend told me another fork works well on M1: hdevalence@33cd428 The major different is he just change |
|
facebook/rocksdb#7714 is already merged, so when will this happen? :) |
|
if you're updating the rocksdb submodule, don't forget to update the diff --git a/librocksdb-sys/build_version.cc b/librocksdb-sys/build_version.cc
index 03e7541..f4328c8 100644
--- a/librocksdb-sys/build_version.cc
+++ b/librocksdb-sys/build_version.cc
@@ -1,4 +1,4 @@
#include "build_version.h"
-const char* rocksdb_build_git_sha = "rocksdb_build_git_sha:@48bfca38f6f175435052a59791922a1a453d9609@";
-const char* rocksdb_build_git_date = "rocksdb_build_git_date:@2020/07/15 17:54:15@";
+const char* rocksdb_build_git_sha = "rocksdb_build_git_sha:@eee0af9af179063f189680e2bd79900de2f9fc6f@";
+const char* rocksdb_build_git_date = "rocksdb_build_git_date:@2020/12/05 14:17:11@";
const char* rocksdb_build_compile_date = __DATE__;I assume we're waiting for a rocksdb release containing this fix? |
|
FYI there's a new rocksdb release containing the fix. |
|
Did anyone happen to benchmark this? Nothing serious, I'm just curious. :) |
|
There is a |
I'm confusing about RocksDB releases, I confirmed Apple Silicon support are not included in 6.15.x, it should in 6.16.0 |
|
A new rocksdb release is available: https://github.com/facebook/rocksdb/releases Can we please merge this soon? |
|
sorry, couldn't help myself #503 😄 |
|
I'm still getting this on a much newer version: This is a close issue, but still seems to be happening? UPDATE: I solved it. Turns out cargo was not install using homebrew, and was a toolchain whose target had persisted from an older mac that my files and settings had been migrated from. Uninstall rust and reinstalling it fixed the problem. |
This patch updates rust-rocksdb to correctly build on Apple Silicon (using all native tools). We include patches to rustdb found here: facebook/rocksdb#7714. Additionally, we upgrade the build script and rocksdb libraries to fix compilation. See issue here for more details on the fixes: #482
Note: this is currently using a patched version of rustdb, we should wait until that PR is merged into rocksdb master until considering merging this patch.