You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Closes#1101, which also discussed serde for other RNGs.
implements for ReadRng: probably useless?
implements for ReseedingRng: probably useless since the reseeder will normally be a non-deterministic RNG
corrects bounds for BlockRng: required for ReseedingRng and I guess was never picked up in previous tests?
rand/serde1 now requires rand_core/serde1, required for ReseedingRng and probably sensible
does not implement for OsRng: useless, and easy to skip as a field in structs
does not implement for StdRng or SmallRng: as @kazcw points out, non-stable serialisation would be a pit-fall
does not implement for Hc128Rng: would require https://crates.io/crates/serde-big-array or some workaround until some future MSRV bump but I doubt anyone cares anyway
I'm tempted to remove the ReadRng and possibly ReseedingRng support but there doesn't seem a good reason either way. Thoughts?
I don't have an opinion on ReadRng, because I don't know what it is used for. If it is used on files, serialization makes sense, but why would anyone do that? For /dev/urandom, serialization does not make sense, but I don't see a point of doing this over using OsRng. To be honest, I don't see a convincing use case for ReadRng and would be tempted to deprecate it.
I think ReseedingRng almost always makes the RNG non-deterministic, so I don't think serialization makes sense?
I agree that the implementation for BlockRng should be added.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
vks
left a comment
Closes #1101, which also discussed serde for other RNGs.
ReadRng: probably useless?ReseedingRng: probably useless since the reseeder will normally be a non-deterministic RNGBlockRng: required forReseedingRngand I guess was never picked up in previous tests?rand/serde1now requiresrand_core/serde1, required forReseedingRngand probably sensibleOsRng: useless, and easy to skip as a field in structsStdRngorSmallRng: as @kazcw points out, non-stable serialisation would be a pit-fallHc128Rng: would require https://crates.io/crates/serde-big-array or some workaround until some future MSRV bump but I doubt anyone cares anywayI'm tempted to remove the
ReadRngand possiblyReseedingRngsupport but there doesn't seem a good reason either way. Thoughts?