Conversation
Now that the MSRV is >= 1.60, we can use `#[cfg(target_has_atomic = "ptr")]` to conditionally compile `lazy.rs`. We should probably also move other atomic/lazy code into lazy.rs, but that can wait for a followup PR. I also slightly cleaned up the `rndr.rs` code to make things a bit more readable, let me know if you want me to split it off into its own PR. Signed-off-by: Joe Richey <joerichey@google.com>
newpavlov
reviewed
Jan 10, 2025
newpavlov
left a comment
Member
There was a problem hiding this comment.
Considering that lazy is used only in two opt-in modules, I think #[path = "../lazy.rs"] is fine, especially considering that it also allows us to remove #![allow(dead_code)]. But it could be a different story if other atomic code is moved into the lazy module.
Could you move the RNDR cleanup into a separate PR?
Merged
Member
|
I applied the suggested rndr tweaks in #586. |
Member
Author
|
Closing as the remaining changes to the lazy module should wait until if we start moving other atomic code into the lazy module. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that the MSRV is >= 1.60, we can use
#[cfg(target_has_atomic = "ptr")]to conditionally compilelazy.rs. We should probably also move other atomic/lazy code into lazy.rs, but that can wait for a followup PR.I also slightly cleaned up the
rndr.rscode to make things a bit more readable and to have thestdimplementation take precedence over theasm-based implementation. Let me know if you want me to split it off into its own PR.