Gate use of unstable try_trait_v2 feature#481
Closed
nicholasbishop wants to merge 1 commit intorust-osdev:mainfrom
Closed
Gate use of unstable try_trait_v2 feature#481nicholasbishop wants to merge 1 commit intorust-osdev:mainfrom
nicholasbishop wants to merge 1 commit intorust-osdev:mainfrom
Conversation
Add a new enabled-by-default `unstable_try_trait` feature to the `uefi` library to control whether the unstable `try_trait_v2` rustc feature is enabled. It seems like there's still a fair amount of discussion around what the Try API should look like in the tracking issue for try_trait_v2. This could lead to the API being changed in the nightly compiler, and breaking uefi-rs compilation (which is particularly annoying when using a released version rather than the latest git version). Users who want to avoid that problem can now disable `unstable_try_trait`. rust-osdev#452
9659a59 to
4ce2da0
Compare
Member
|
For the record, I'm in favor of #479. I wrote my thoughts about breaking changes in uefi-rs here #495 (comment) IMHO the small code changes of dropping this feature are not worth it to create possibly future technical debt (by keeping it, thus, having more complexity). I do not insist on it and I'm open for discussions :) |
Collaborator
|
Yeah, I agree with what @phip1611 said. When I initially thought of the solution based on a feature gate, I didn't realize it would lead to so many small changes and still has downsides 😅 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a new enabled-by-default
unstable_try_traitfeature to theuefilibrary to control whether the unstable
try_trait_v2rustc feature isenabled.
It seems like there's still a fair amount of discussion around what the
Try API should look like in the tracking issue for try_trait_v2. This
could lead to the API being changed in the nightly compiler, and
breaking uefi-rs compilation (which is particularly annoying when using
a released version rather than the latest git version). Users who want
to avoid that problem can now disable
unstable_try_trait.#452