Let AWS-LC use the BoringSSL path for BIO_METHOD#2562
Merged
botovq merged 1 commit intorust-openssl:masterfrom Jan 2, 2026
Merged
Let AWS-LC use the BoringSSL path for BIO_METHOD#2562botovq merged 1 commit intorust-openssl:masterfrom
botovq merged 1 commit intorust-openssl:masterfrom
Conversation
alex
reviewed
Jan 2, 2026
Collaborator
alex
left a comment
There was a problem hiding this comment.
I think we can probably further clean this up, I think BIO_set_num can just be deleted and I guess BIO_METHOD can be normal foreign-type now?
Contributor
Author
|
Thanks. I think you're right. How's this? Not sure if this is semver compatible and how to make it so, though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not entirely sure about this one, since I don't know how this managed to work for AWS-LC so far. In any case, I think we want to get rid of the "else" branch of this cfg_if.