Add helper to return &mut SslRef from stream#2223
Add helper to return &mut SslRef from stream#2223jmayclin wants to merge 2 commits intorust-openssl:masterfrom
Conversation
|
There is a failure in the CI, but it looks to be unrelated to my PR.
|
|
CI should be fixed once you rebase on main |
48398b6 to
a323dd0
Compare
|
Hi @alex, wondering if you could take a look at this? Thanks! |
|
Unfortunately I don't use the |
|
Ah, I understand. Do you know how I could go about getting this reviewed? |
|
Hopefully Steven will review as he has time.
…On Mon, May 13, 2024 at 3:56 PM James Mayclin ***@***.***> wrote:
Ah, I understand. Do you know how I could go about getting this reviewed?
—
Reply to this email directly, view it on GitHub
<#2223 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAAGBD7M7V7ETAUAUFT2BTZCELIJAVCNFSM6AAAAABGTJDCU2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBYGY4DONBYGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
All that is necessary for evil to succeed is for good people to do nothing.
|
|
Hi @sfackler, I am still interested in getting this merged in. Please let me know if you have any feedback or concerns! |
|
Hi @sfackler! Just ran into this again, so would love to get this PR merged. |
|
Hi @sfackler - resurfacing this since it came up again recently. This change would still be very helpful. |
Currently there is no way to retrieve a mutable reference to the underlying
SslRefgiven someSslStream. This PR adds anssl_mutmethod to do that.