Skip to content

Add helper to return &mut SslRef from stream#2223

Open
jmayclin wants to merge 2 commits intorust-openssl:masterfrom
jmayclin:mut-ssl-stream
Open

Add helper to return &mut SslRef from stream#2223
jmayclin wants to merge 2 commits intorust-openssl:masterfrom
jmayclin:mut-ssl-stream

Conversation

@jmayclin
Copy link
Copy Markdown
Contributor

Currently there is no way to retrieve a mutable reference to the underlying SslRef given some SslStream. This PR adds an ssl_mut method to do that.

@jmayclin
Copy link
Copy Markdown
Contributor Author

There is a failure in the CI, but it looks to be unrelated to my PR.

error: package `cc v1.0.95` cannot be built because it requires rustc 1.63 or newer, 
while the currently active rustc version is 1.56.0

cc bumped their MSRV in the latest release (3 days ago): https://github.com/rust-lang/cc-rs/releases/tag/1.0.95, which appears to be the reason for this failure.

@botovq
Copy link
Copy Markdown
Contributor

botovq commented Apr 28, 2024

CI should be fixed once you rebase on main

@jmayclin
Copy link
Copy Markdown
Contributor Author

Hi @alex, wondering if you could take a look at this? Thanks!

@alex
Copy link
Copy Markdown
Collaborator

alex commented May 13, 2024

Unfortunately I don't use the ssl layer of this package, only the libcrypto parts, so I'm not familiar with this part of the code or the semantics to know if this raises any potential issues.

@jmayclin
Copy link
Copy Markdown
Contributor Author

Ah, I understand. Do you know how I could go about getting this reviewed?

@alex
Copy link
Copy Markdown
Collaborator

alex commented May 13, 2024 via email

@jmayclin
Copy link
Copy Markdown
Contributor Author

Hi @sfackler, I am still interested in getting this merged in. Please let me know if you have any feedback or concerns!

@jmayclin
Copy link
Copy Markdown
Contributor Author

jmayclin commented Apr 25, 2025

Hi @sfackler! Just ran into this again, so would love to get this PR merged.

@jmayclin jmayclin closed this May 24, 2025
@jmayclin jmayclin reopened this May 24, 2025
@kaukabrizvi
Copy link
Copy Markdown

Hi @sfackler - resurfacing this since it came up again recently. This change would still be very helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants