fix: BIO_set_retry_write when BIO_CTRL_FLUSH to allow writer returns WouldBlock on flush#1922
Open
ihciah wants to merge 1 commit intorust-openssl:masterfrom
Open
fix: BIO_set_retry_write when BIO_CTRL_FLUSH to allow writer returns WouldBlock on flush#1922ihciah wants to merge 1 commit intorust-openssl:masterfrom
ihciah wants to merge 1 commit intorust-openssl:masterfrom
Conversation
Author
|
As a memo: |
Collaborator
|
Could you add a test for this change? |
…WouldBlock on flush
Author
Sure. I've added a new test for it. But since openssl still has bug(openssl/openssl#20919) on flush, to make the the test pass, I only tested read and write. Once the openssl issue solved, change |
Author
|
Hi! Just a remind. @sfackler |
Collaborator
|
I will look at this once the upstream change lands so it can actually be tested. |
Author
|
Hi! @sfackler |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a BIO_flush related issue. According to openssl doc(link):
We have to call
BIO_set_retry_writeonretriable_errorlike WouldBlock. Otherwise, when theflushreturns WouldBlock, it will fail.Since we usually wrap openssl with a
TcpStream, there is no buffer inside andflushalways returnsOk(()), this issue is not obvious. However, if users use a buffered io, the flush support will be essential.However, only fixes rust-openssl is not enough. I found a problem in openssl that makes this change not working. The issue can be found at openssl/openssl#20919 and I will try to fix it.