Merged
Conversation
This fixes GCC 15 building Signed-off-by: Ryan Brue <ryanbrue.dev@gmail.com>
Collaborator
|
Thanks for the contribution. I'll merge this with the CI errors now and take some time to fixup the build and publish a new package version. I'm afraid Rus-Onig has been been a little neglected but this improvement is much appreciated. |
|
Please, could you tell me if rust is already using those fixes? |
Collaborator
|
The version of oniguruma we track could perhaps do with updating again. The changes in this pr are merged and in the latest crate release though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix GCC 15 building per #191