onig_sys: Add cargo:rerun-if-env-changed flags#167
Merged
iwillspeak merged 2 commits intorust-onig:mainfrom Feb 7, 2022
Merged
onig_sys: Add cargo:rerun-if-env-changed flags#167iwillspeak merged 2 commits intorust-onig:mainfrom
iwillspeak merged 2 commits intorust-onig:mainfrom
Conversation
This properly reruns the build if the value of $RUSTONIG_DYNAMIC_LIBONING changes (and all the similar values) See the cargo reference on build scripts "change detection" for more details: https://doc.rust-lang.org/cargo/reference/build-scripts.html#change-detection I have conirmed this works both on the latest stable and the MSRV (Rust 1.50)
iwillspeak
reviewed
Feb 7, 2022
Its only our responsibility to filter out if the name starts with 'RUSTONIG'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This properly reruns the build if the value of $RUSTONIG_DYNAMIC_LIBONING
changes (and all the similar values)
See the cargo reference on build scripts "change detection" for more details.
I have conirmed this works both on the latest stable and the MSRV (Rust 1.50)