ndk/input_queue: Remove Result wrapping from has_events()#294
Merged
ndk/input_queue: Remove Result wrapping from has_events()#294
Result wrapping from has_events()#294Conversation
20 tasks
4bf3edf to
fd1982a
Compare
This was referenced Jun 12, 2022
Merged
After having blindly retained error handling in [#292], it turns out the underlying [`InputQueue::hasEvents()` implementation] doesn't ever return an error nor does the documentation state that this is possible. As such, mimic what we're already doing in `fn pre_dispatch()` and panic if the value doesn't represent a `bool`. [`InputQueue::hasEvents()` implementation]: https://cs.android.com/android/platform/superproject/+/master:frameworks/base/core/jni/android_view_InputQueue.cpp;l=88-91;drc=5497dd365e9135805636a40267cb98e2e2b78ee6 [#292]: #292
fd1982a to
e7d4b4d
Compare
msiglreith
approved these changes
Jul 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After having blindly retained error handling in #292, it turns out the underlying
InputQueue::hasEvents()implementation doesn't ever return an error nor does the documentation state that this is possible.As such, mimic what we're already doing in
fn pre_dispatch()and panic if the value doesn't represent abool.