Release ndk-build-0.6.0, cargo-apk-0.9.2#289
Merged
Conversation
20 tasks
4178f66 to
a8078cd
Compare
Moves the NDK r23 `-lgcc` workaround to `ndk_build::cargo::cargo_ndk()`, so that `cargo apk --` blanket invocations receive it too. This should solve `winit` CI failures again now that GitHub Actions Virtual Enviroments are finishing up the migration to NDK r23.
a8078cd to
5451ed2
Compare
Member
Author
|
@msiglreith Shall we get this out of the door now to get rid of red CI in |
MarijnS95
commented
Jun 13, 2022
Comment on lines
+14
to
+22
| anyhow = "1.0.57" | ||
| cargo-subcommand = "0.7" | ||
| dunce = "1" | ||
| env_logger = "0.9" | ||
| log = "0.4" | ||
| ndk-build = { path = "../ndk-build", version = "0.6.0" } | ||
| serde = "1" | ||
| thiserror = "1.0.31" | ||
| toml = "0.5" |
Member
Author
There was a problem hiding this comment.
This passes -Zminimal-versions, I didn't bother to find the minimal working ones for anyhow/thiserror though.
msiglreith
approved these changes
Jun 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the NDK r23
-lgccworkaround tondk_build::cargo::cargo_ndk(), so thatcargo apk --blanket invocations receive it too. This should solvewinitCI failures again now that GitHub Actions Virtual Enviroments are finishing up the migration to NDK r23.