cargo-apk: Append --target to blanket cargo apk -- calls when not provided#287
Merged
cargo-apk: Append --target to blanket cargo apk -- calls when not provided#287
--target to blanket cargo apk -- calls when not provided#287Conversation
55e7688 to
e65178a
Compare
20 tasks
Member
Author
|
@msiglreith Thoughts? If we want this, we should probably get it in right in the next patch release (that I'd like to do soon™ to fix the Or is there a command you think may not support |
e65178a to
257362b
Compare
… provided When the user doesn't provide a `--target` we default the triple to the currently connected device over `adb`, or otherwise fall back to `aarch64`. While this triple is always used to determine what NDK environment to provide, it's never added to the arguments passed after `--`; for example a `cargo apk -- test --no-run` will try to build tests for the host unless explicitly called with `--target`.
257362b to
04a47ad
Compare
msiglreith
approved these changes
Jun 10, 2022
Contributor
msiglreith
left a comment
There was a problem hiding this comment.
fine for me
check, build, test, clippy, doc and bench seem all to support it which are probably the most used CI configurations and which might user want through cargo-apk
Member
Author
|
Let's go for it then, this is probably a net-improvement and otherwise we'll come up with an alternative 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #286, #283
When the user doesn't provide a
--targetwe default the triple to the currently connected device overadb, or otherwise fall back toaarch64.While this triple is always used to determine what NDK environment to provide, it's never added to the arguments passed after
--; for example acargo apk -- test --no-runwill try to build tests for the host unless explicitly called with--target.I can't currently think of any command that one might want to run under
cargo apk --with an NDK environment, but without support for--target. If there is, that's a valid argument to not pass this flag (but perhaps clearly document it, maybe even warn about it if we don't find--targetin the call?).