ndk-glue: Document lock behaviour in Event and ensure pointer equality#174
Merged
msiglreith merged 1 commit intomasterfrom Aug 7, 2021
Merged
ndk-glue: Document lock behaviour in Event and ensure pointer equality#174msiglreith merged 1 commit intomasterfrom
Event and ensure pointer equality#174msiglreith merged 1 commit intomasterfrom
Conversation
This completes #134 by applying the same pointer-equality check in `on_input_queue_destroyed` to `on_window_destroyed`, and documents when the user should hold on to or release any of the `RWLock`s to ensure proper lifetimes for dependencies like surfaces in graphics APIs.
MarijnS95
commented
Aug 7, 2021
| @@ -122,8 +122,16 @@ pub enum Event { | |||
| WindowCreated, | |||
Member
Author
There was a problem hiding this comment.
Should we add some docs about acquiring and holding the lock here too? And on InputQueueCreated?
msiglreith
approved these changes
Aug 7, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This completes #134 by applying the same pointer-equality check in
on_input_queue_destroyedtoon_window_destroyed, and documents when the user should hold on to or release any of theRWLocks to ensure proper lifetimes for dependencies like surfaces in graphics APIs.